Skip to content

feat: set default domain for thirdweb auth #5196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2024
Merged

feat: set default domain for thirdweb auth #5196

merged 1 commit into from
Oct 28, 2024
+1 −1

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 28, 2024 •
edited by pr-codex bot
Loading

Problem solved

Addresses CNCT-2132

PR-Codex overview

This PR updates the domain configuration in the thirdwebAuth object to use a default value of "thirdweb.com" if the environment variable NEXT_PUBLIC_THIRDWEB_AUTH_DOMAIN is not set.

Detailed summary

  • Changed the domain property in the thirdwebAuth configuration from an empty string to "thirdweb.com" as the default value.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 9:22pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 28, 2024 9:22pm
thirdweb-www ⬜️ Skipped (Inspect) Oct 28, 2024 9:22pm
wallet-ui ⬜️ Skipped (Inspect) Oct 28, 2024 9:22pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 28, 2024 19:29 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 28, 2024 19:29 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 28, 2024 19:29 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: bb44352

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Oct 28, 2024
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Oct 28, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@joaquim-verges joaquim-verges marked this pull request as ready for review October 28, 2024 19:29
@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.9 KB (0%) 859 ms (0%) 4.7 s (+53.03% 🔺) 5.6 s
thirdweb (cjs) 102.73 KB (0%) 2.1 s (0%) 5.8 s (-27.04% 🔽) 7.8 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 254 ms (+40.71% 🔺) 350 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 75 ms (+8.98% 🔺) 85 ms
thirdweb/react (minimal + tree-shaking) 17.34 KB (0%) 347 ms (0%) 1.1 s (+63.03% 🔺) 1.5 s

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 28, 2024 •
edited
Loading

Merge activity

@joaquim-verges
feat: set default domain for thirdweb auth (#5196)
bb44352 
## Problem solved

Addresses CNCT-2132

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the `domain` configuration in the `createAuth` function for the `thirdwebAuth` object, changing its default value to "thirdweb.com".

### Detailed summary
- Updated the `domain` property in `createAuth` from an empty string to "thirdweb.com".

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@joaquim-verges joaquim-verges force-pushed the feat_set_default_domain_for_thirdweb_auth branch from f46afe5 to bb44352 Compare October 28, 2024 20:49
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 28, 2024 20:50 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 28, 2024 20:50 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 28, 2024 20:50 Inactive
@codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.30%. Comparing base (aa0f397) to head (bb44352).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5196   +/-   ##
=======================================
  Coverage   45.30%   45.30%           
=======================================
  Files        1067     1067           
  Lines       55304    55304           
  Branches     3970     3970           
=======================================
  Hits        25054    25054           
  Misses      29557    29557           
  Partials      693      693
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from aa0f397
packages 40.31% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@graphite-app graphite-app bot merged commit bb44352 into main Oct 28, 2024
29 of 30 checks passed
@graphite-app graphite-app bot deleted the feat_set_default_domain_for_thirdweb_auth branch October 28, 2024 20:52
@vercel vercel bot temporarily deployed to Production – docs-v2 October 28, 2024 20:52 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 28, 2024 20:52 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www October 28, 2024 20:52 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@gregfromstl gregfromstl Awaiting requested review from gregfromstl

Assignees

No one assigned

Labels

Playground Changes involving the Playground codebase.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joaquim-verges @jnsdls